Skip to content

[CameraView] Android - Fix SetSurfaceProvider crash #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheCodeTraveler merged 3 commits into from
Jan 21, 2025
Merged

[CameraView] Android - Fix SetSurfaceProvider crash #2449

TheCodeTraveler merged 3 commits into from
Jan 21, 2025

Conversation

@UlriCode
Copy link
Contributor

@UlriCode UlriCode commented Jan 16, 2025

Description of Change

Update both Xamarin.AndroidX.Camera.Camera2 and Xamarin.AndroidX.Camera.View packages.
Fix the call to SetSurfaceProvider that changed with the new packages.

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@UlriCode UlriCode mentioned this pull request Jan 16, 2025
Closed
2 tasks
@TheCodeTraveler TheCodeTraveler added waiting for feedback Waiting for a response from the author or the core team member blocked labels Jan 16, 2025
@TheCodeTraveler
Copy link
Collaborator

TheCodeTraveler commented Jan 16, 2025

I've added the blocked label until we can reproduce the crash.

I've provided more information here on the Issue: #2438 (comment)

@TheCodeTraveler TheCodeTraveler added needs discussion Discuss it on the next Monthly standup and removed blocked waiting for feedback Waiting for a response from the author or the core team member labels Jan 17, 2025
Copilot AI reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/CommunityToolkit.Maui.Camera/CommunityToolkit.Maui.Camera.csproj: Language not supported

TheCodeTraveler
TheCodeTraveler approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @UlriCode! Approved ✅

This PR will automatically merge once you've agreed to the Contributor License Agreement 👍

Just FYI - you can accept the CLA on behalf of yourself, as an individual. In other words, unless your GitHub Account is owned by a corporation, you do not need to accept the CLA on behalf of your employer.

@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) January 18, 2025 00:37
@UlriCode
Copy link
Contributor Author

UlriCode commented Jan 20, 2025

@dotnet-policy-service agree company="AxioCode"

@UlriCode
Copy link
Contributor Author

UlriCode commented Jan 20, 2025

Thanks @UlriCode! Approved ✅

This PR will automatically merge once you've agreed to the Contributor License Agreement 👍

Just FYI - you can accept the CLA on behalf of yourself, as an individual. In other words, unless your GitHub Account is owned by a corporation, you do not need to accept the CLA on behalf of your employer.

Thank you!

My account is owned by my employer, so could not accept on my behalf.
I have now accepted it with my employer's approval.

@TheCodeTraveler TheCodeTraveler merged commit 5555324 into CommunityToolkit:main Jan 21, 2025
14 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@TheCodeTraveler TheCodeTraveler TheCodeTraveler approved these changes

Assignees

No one assigned

Labels

needs discussion Discuss it on the next Monthly standup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Camera view with .NET 9 crashes on Android

4 participants

@UlriCode @TheCodeTraveler @jfversluis @VladislavAntonyuk